feat: add dedicated favicon assets#7
Merged
Merged
Conversation
Runs the chat API on :3001 so it can pair with Coven Cave's dev server (which owns :3000) when Cave's /api/salem proxies to SALEM_CHAT_API_URL. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The favicon previously resolved from /logo.svg (white mark on transparent), which was faint on light browser tabs. Add self-contained favicon assets so the mark stays legible on both light and dark tabs: - public/favicon.svg — OpenCoven monoline mark (white) on a dark rounded tile; crisp at any size for modern browsers. - public/favicon.ico — multi-size 16/32/48 raster (strokes slightly bolded for small-size legibility). - public/apple-icon.png — 180x180 apple-touch-icon. Wire all three into the metadata icons in app/layout.tsx. /logo.svg is unchanged and still used for the in-page header and chat button. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds dedicated favicon assets and updates Next.js metadata configuration so the OpenCoven mark remains legible on both light and dark browser tabs, instead of relying on /logo.svg.
Changes:
- Add a new dedicated
public/favicon.svgasset (self-contained mark on dark tile). - Update
app/layout.tsxmetadata.iconsto referencefavicon.svg,favicon.ico, andapple-icon.png. - Add a convenience dev script to run Next on port
3001.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
public/favicon.svg |
Adds an SVG favicon asset designed for legibility on light/dark tabs. |
app/layout.tsx |
Switches metadata.icons from /logo.svg to dedicated favicon + apple-touch icon assets. |
package.json |
Adds dev:cave script to run the dev server on port 3001. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+13
| icon: [ | ||
| { url: "/favicon.svg", type: "image/svg+xml" }, | ||
| { url: "/favicon.ico", sizes: "any" }, | ||
| ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The favicon previously resolved from
/logo.svg(white mark on transparent), which is faint on light browser tabs. Added self-contained favicon assets so the OpenCoven mark stays legible on both light and dark tabs.public/favicon.svg— OpenCoven monoline mark (white) on a dark rounded tile; crisp at any size for modern browsers.public/favicon.ico— multi-size 16/32/48 raster (strokes slightly bolded for small-size legibility).public/apple-icon.png— 180×180 apple-touch-icon.Wired all three into
metadata.iconsinapp/layout.tsx./logo.svgis unchanged and still used for the in-page header and chat button.Design notes
#0a0a0a/ OG card) makes the favicon self-contained: the white mark shows on dark tabs, the dark tile + mark show on light tabs.Verification
npm run build→ ✓ compiled, all routes built; built HTML head emits all three icon<link>s (favicon.svg,favicon.ico,apple-icon.png).npm test→validate-opencoven-port: ok🤖 Generated with Claude Code